Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the prettier organize imports plugin #1507

Closed
wants to merge 2 commits into from

Conversation

NullVoxPopuli
Copy link
Contributor

@NullVoxPopuli NullVoxPopuli commented Nov 22, 2023

Introduced in: #1462

I'm not a fan of this, because there is currently a conflict with eslint/prettier where they can't be ran without creating git diffs.

If this is going to be viable, I need to find the eslint rule that is changing import order.

This was one thing not in the original lint extractions, because the behavior seemed unstable.

  • eslint -> caused git diff
  • prettier -> caused git diff

(unless both ran together)

@NullVoxPopuli NullVoxPopuli mentioned this pull request Nov 22, 2023
@NullVoxPopuli
Copy link
Contributor Author

oh turns out we don't want this, because it was intentionally disabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant